aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authornee <nee.git@cock.li>2017-11-26 22:14:30 +0100
committernee <nee.git@cock.li>2017-11-26 22:14:30 +0100
commitfdd3d63098f6411b2bec99fbca96543866374de7 (patch)
treeb20940b903e462f8ad330f17840f3d7f0b20fefb
parent50f9f23ff19a4f577c429d80411378d6a1747725 (diff)
downloadgnu-social-fdd3d63098f6411b2bec99fbca96543866374de7.tar
gnu-social-fdd3d63098f6411b2bec99fbca96543866374de7.zip
Don't write the config file when --skip-config flag is given to the installer.
* scripts/installer_cli.php: Read the arguments list before checking if the config file is writeable.
-rw-r--r--lib/installer.php14
-rwxr-xr-xscripts/install_cli.php2
2 files changed, 9 insertions, 7 deletions
diff --git a/lib/installer.php b/lib/installer.php
index 346c706d61..e73216f18d 100644
--- a/lib/installer.php
+++ b/lib/installer.php
@@ -85,7 +85,7 @@ abstract class Installer
$pass = true;
$config = INSTALLDIR.'/config.php';
- if (file_exists($config)) {
+ if (!$this->skipConfig && file_exists($config)) {
if (!is_writable($config) || filesize($config) > 0) {
if (filesize($config) == 0) {
$this->warning('Config file "config.php" already exists and is empty, but is not writable.');
@@ -126,14 +126,16 @@ abstract class Installer
}
// @fixme this check seems to be insufficient with Windows ACLs
- if (!is_writable(INSTALLDIR)) {
+ if (!$this->skipConfig && !is_writable(INSTALLDIR)) {
$this->warning(sprintf('Cannot write config file to: <code>%s</code></p>', INSTALLDIR),
sprintf('On your server, try this command: <code>chmod a+w %s</code>', INSTALLDIR));
$pass = false;
}
// Check the subdirs used for file uploads
- $fileSubdirs = array('avatar', 'file');
+ // TODO get another flag for this --skipFileSubdirCreation
+ if (!$this->skipConfig) {
+ $fileSubdirs = array($this->avatarDir, $this->fileDir);
foreach ($fileSubdirs as $fileSubdir) {
$fileFullPath = INSTALLDIR."/$fileSubdir";
if (!file_exists($fileFullPath)) {
@@ -148,7 +150,7 @@ abstract class Installer
$pass = false;
}
}
-
+ }
return $pass;
}
@@ -580,10 +582,10 @@ abstract class Installer
return false;
}
+ if (!$this->skipConfig) {
// Make sure we can write to the file twice
$oldUmask = umask(000);
- if (!$this->skipConfig) {
$this->updateStatus("Writing config file...");
$res = $this->writeConf();
@@ -616,12 +618,12 @@ abstract class Installer
$this->updateStatus("Can't write to config file.", true);
return false;
}
- }
// Restore original umask
umask($oldUmask);
// Set permissions back to something decent
chmod(INSTALLDIR.'/config.php', 0644);
+ }
$scheme = $this->ssl === 'always' ? 'https' : 'http';
$link = "{$scheme}://{$this->server}/{$this->path}";
diff --git a/scripts/install_cli.php b/scripts/install_cli.php
index 815418aaab..da5f0f4b0c 100755
--- a/scripts/install_cli.php
+++ b/scripts/install_cli.php
@@ -47,10 +47,10 @@ class CliInstaller extends Installer
*/
function main()
{
+ if ($this->prepare()) {
if (!$this->checkPrereqs()) {
return false;
}
- if ($this->prepare()) {
return $this->handle();
} else {
$this->showHelp();